Skip to content

Fix US5 E2E breaking CI#214

Merged
SacciadisG merged 5 commits into
masterfrom
fix-breaking-poi-ci
Apr 5, 2026
Merged

Fix US5 E2E breaking CI#214
SacciadisG merged 5 commits into
masterfrom
fix-breaking-poi-ci

Conversation

@Vinuyans

@Vinuyans Vinuyans commented Apr 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Maestro test can't find markers on iOS

Related Issues

Changes Made

  • Fixed testID for iOS

Testing

  • Manual testing performed (describe briefly)
  • Unit tests added or updated (if applicable)
  • All tests pass locally / in CI

Checklist (Author & Reviewer)

  • Code follows project conventions
  • The change was run locally and works as expected
  • Acceptance criteria met
  • No breaking changes

@Vinuyans Vinuyans requested a review from SacciadisG April 5, 2026 16:31
@Vinuyans Vinuyans self-assigned this Apr 5, 2026
Copilot AI review requested due to automatic review settings April 5, 2026 16:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to address Maestro iOS E2E failures where map markers are not discoverable by test selectors by adjusting how testID/nativeID are assigned to POI markers.

Changes:

  • Assign testID and nativeID for POI markers unconditionally (previously platform-gated).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread components/map/poi-marker.tsx Outdated
Comment thread components/map/poi-marker.tsx Outdated
@codecov

codecov Bot commented Apr 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud

sonarqubecloud Bot commented Apr 5, 2026

Copy link
Copy Markdown

@SacciadisG SacciadisG left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. We'll focus on adding these in short time.

@SacciadisG SacciadisG merged commit 8ba60a2 into master Apr 5, 2026
4 checks passed
@SacciadisG SacciadisG deleted the fix-breaking-poi-ci branch April 5, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants